1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24#include <linux/file.h>
25#include <linux/fs.h>
26#include <linux/fsnotify.h>
27#include <linux/backing-dev.h>
28#include <linux/init.h>
29#include <linux/ioctl.h>
30#include <linux/module.h>
31#include <linux/mount.h>
32#include <linux/namei.h>
33#include <linux/pagemap.h>
34#include <linux/poll.h>
35#include <linux/slab.h>
36#include <linux/parser.h>
37
38#include <asm/prom.h>
39#include <asm/spu.h>
40#include <asm/spu_priv1.h>
41#include <asm/uaccess.h>
42
43#include "spufs.h"
44
45struct spufs_sb_info {
46 int debug;
47};
48
49static struct kmem_cache *spufs_inode_cache;
50char *isolated_loader;
51static int isolated_loader_size;
52
53static struct spufs_sb_info *spufs_get_sb_info(struct super_block *sb)
54{
55 return sb->s_fs_info;
56}
57
58static struct inode *
59spufs_alloc_inode(struct super_block *sb)
60{
61 struct spufs_inode_info *ei;
62
63 ei = kmem_cache_alloc(spufs_inode_cache, GFP_KERNEL);
64 if (!ei)
65 return NULL;
66
67 ei->i_gang = NULL;
68 ei->i_ctx = NULL;
69 ei->i_openers = 0;
70
71 return &ei->vfs_inode;
72}
73
74static void
75spufs_destroy_inode(struct inode *inode)
76{
77 kmem_cache_free(spufs_inode_cache, SPUFS_I(inode));
78}
79
80static void
81spufs_init_once(void *p)
82{
83 struct spufs_inode_info *ei = p;
84
85 inode_init_once(&ei->vfs_inode);
86}
87
88static struct inode *
89spufs_new_inode(struct super_block *sb, int mode)
90{
91 struct inode *inode;
92
93 inode = new_inode(sb);
94 if (!inode)
95 goto out;
96
97 inode->i_mode = mode;
98 inode->i_uid = current_fsuid();
99 inode->i_gid = current_fsgid();
100 inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
101out:
102 return inode;
103}
104
105static int
106spufs_setattr(struct dentry *dentry, struct iattr *attr)
107{
108 struct inode *inode = dentry->d_inode;
109
110 if ((attr->ia_valid & ATTR_SIZE) &&
111 (attr->ia_size != inode->i_size))
112 return -EINVAL;
113 return inode_setattr(inode, attr);
114}
115
116
117static int
118spufs_new_file(struct super_block *sb, struct dentry *dentry,
119 const struct file_operations *fops, int mode,
120 size_t size, struct spu_context *ctx)
121{
122 static const struct inode_operations spufs_file_iops = {
123 .setattr = spufs_setattr,
124 };
125 struct inode *inode;
126 int ret;
127
128 ret = -ENOSPC;
129 inode = spufs_new_inode(sb, S_IFREG | mode);
130 if (!inode)
131 goto out;
132
133 ret = 0;
134 inode->i_op = &spufs_file_iops;
135 inode->i_fop = fops;
136 inode->i_size = size;
137 inode->i_private = SPUFS_I(inode)->i_ctx = get_spu_context(ctx);
138 d_add(dentry, inode);
139out:
140 return ret;
141}
142
143static void
144spufs_delete_inode(struct inode *inode)
145{
146 struct spufs_inode_info *ei = SPUFS_I(inode);
147
148 if (ei->i_ctx)
149 put_spu_context(ei->i_ctx);
150 if (ei->i_gang)
151 put_spu_gang(ei->i_gang);
152 clear_inode(inode);
153}
154
155static void spufs_prune_dir(struct dentry *dir)
156{
157 struct dentry *dentry, *tmp;
158
159 mutex_lock(&dir->d_inode->i_mutex);
160 list_for_each_entry_safe(dentry, tmp, &dir->d_subdirs, d_u.d_child) {
161 spin_lock(&dcache_lock);
162 spin_lock(&dentry->d_lock);
163 if (!(d_unhashed(dentry)) && dentry->d_inode) {
164 dget_locked(dentry);
165 __d_drop(dentry);
166 spin_unlock(&dentry->d_lock);
167 simple_unlink(dir->d_inode, dentry);
168 spin_unlock(&dcache_lock);
169 dput(dentry);
170 } else {
171 spin_unlock(&dentry->d_lock);
172 spin_unlock(&dcache_lock);
173 }
174 }
175 shrink_dcache_parent(dir);
176 mutex_unlock(&dir->d_inode->i_mutex);
177}
178
179
180static int spufs_rmdir(struct inode *parent, struct dentry *dir)
181{
182
183 spufs_prune_dir(dir);
184 d_drop(dir);
185
186 return simple_rmdir(parent, dir);
187}
188
189static int spufs_fill_dir(struct dentry *dir,
190 const struct spufs_tree_descr *files, int mode,
191 struct spu_context *ctx)
192{
193 struct dentry *dentry, *tmp;
194 int ret;
195
196 while (files->name && files->name[0]) {
197 ret = -ENOMEM;
198 dentry = d_alloc_name(dir, files->name);
199 if (!dentry)
200 goto out;
201 ret = spufs_new_file(dir->d_sb, dentry, files->ops,
202 files->mode & mode, files->size, ctx);
203 if (ret)
204 goto out;
205 files++;
206 }
207 return 0;
208out:
209
210
211
212
213
214
215
216
217
218 list_for_each_entry_safe(dentry, tmp, &dir->d_subdirs, d_u.d_child) {
219 dput(dentry);
220 }
221
222 shrink_dcache_parent(dir);
223 return ret;
224}
225
226static int spufs_dir_close(struct inode *inode, struct file *file)
227{
228 struct spu_context *ctx;
229 struct inode *parent;
230 struct dentry *dir;
231 int ret;
232
233 dir = file->f_path.dentry;
234 parent = dir->d_parent->d_inode;
235 ctx = SPUFS_I(dir->d_inode)->i_ctx;
236
237 mutex_lock_nested(&parent->i_mutex, I_MUTEX_PARENT);
238 ret = spufs_rmdir(parent, dir);
239 mutex_unlock(&parent->i_mutex);
240 WARN_ON(ret);
241
242
243 spu_forget(ctx);
244
245 return dcache_dir_close(inode, file);
246}
247
248const struct file_operations spufs_context_fops = {
249 .open = dcache_dir_open,
250 .release = spufs_dir_close,
251 .llseek = dcache_dir_lseek,
252 .read = generic_read_dir,
253 .readdir = dcache_readdir,
254 .fsync = simple_sync_file,
255};
256EXPORT_SYMBOL_GPL(spufs_context_fops);
257
258static int
259spufs_mkdir(struct inode *dir, struct dentry *dentry, unsigned int flags,
260 int mode)
261{
262 int ret;
263 struct inode *inode;
264 struct spu_context *ctx;
265
266 ret = -ENOSPC;
267 inode = spufs_new_inode(dir->i_sb, mode | S_IFDIR);
268 if (!inode)
269 goto out;
270
271 if (dir->i_mode & S_ISGID) {
272 inode->i_gid = dir->i_gid;
273 inode->i_mode &= S_ISGID;
274 }
275 ctx = alloc_spu_context(SPUFS_I(dir)->i_gang);
276 SPUFS_I(inode)->i_ctx = ctx;
277 if (!ctx)
278 goto out_iput;
279
280 ctx->flags = flags;
281 inode->i_op = &simple_dir_inode_operations;
282 inode->i_fop = &simple_dir_operations;
283 if (flags & SPU_CREATE_NOSCHED)
284 ret = spufs_fill_dir(dentry, spufs_dir_nosched_contents,
285 mode, ctx);
286 else
287 ret = spufs_fill_dir(dentry, spufs_dir_contents, mode, ctx);
288
289 if (ret)
290 goto out_free_ctx;
291
292 if (spufs_get_sb_info(dir->i_sb)->debug)
293 ret = spufs_fill_dir(dentry, spufs_dir_debug_contents,
294 mode, ctx);
295
296 if (ret)
297 goto out_free_ctx;
298
299 d_instantiate(dentry, inode);
300 dget(dentry);
301 inc_nlink(dir);
302 inc_nlink(dentry->d_inode);
303 goto out;
304
305out_free_ctx:
306 spu_forget(ctx);
307 put_spu_context(ctx);
308out_iput:
309 iput(inode);
310out:
311 return ret;
312}
313
314static int spufs_context_open(struct dentry *dentry, struct vfsmount *mnt)
315{
316 int ret;
317 struct file *filp;
318
319 ret = get_unused_fd();
320 if (ret < 0) {
321 dput(dentry);
322 mntput(mnt);
323 goto out;
324 }
325
326 filp = dentry_open(dentry, mnt, O_RDONLY, current_cred());
327 if (IS_ERR(filp)) {
328 put_unused_fd(ret);
329 ret = PTR_ERR(filp);
330 goto out;
331 }
332
333 filp->f_op = &spufs_context_fops;
334 fd_install(ret, filp);
335out:
336 return ret;
337}
338
339static struct spu_context *
340spufs_assert_affinity(unsigned int flags, struct spu_gang *gang,
341 struct file *filp)
342{
343 struct spu_context *tmp, *neighbor, *err;
344 int count, node;
345 int aff_supp;
346
347 aff_supp = !list_empty(&(list_entry(cbe_spu_info[0].spus.next,
348 struct spu, cbe_list))->aff_list);
349
350 if (!aff_supp)
351 return ERR_PTR(-EINVAL);
352
353 if (flags & SPU_CREATE_GANG)
354 return ERR_PTR(-EINVAL);
355
356 if (flags & SPU_CREATE_AFFINITY_MEM &&
357 gang->aff_ref_ctx &&
358 gang->aff_ref_ctx->flags & SPU_CREATE_AFFINITY_MEM)
359 return ERR_PTR(-EEXIST);
360
361 if (gang->aff_flags & AFF_MERGED)
362 return ERR_PTR(-EBUSY);
363
364 neighbor = NULL;
365 if (flags & SPU_CREATE_AFFINITY_SPU) {
366 if (!filp || filp->f_op != &spufs_context_fops)
367 return ERR_PTR(-EINVAL);
368
369 neighbor = get_spu_context(
370 SPUFS_I(filp->f_dentry->d_inode)->i_ctx);
371
372 if (!list_empty(&neighbor->aff_list) && !(neighbor->aff_head) &&
373 !list_is_last(&neighbor->aff_list, &gang->aff_list_head) &&
374 !list_entry(neighbor->aff_list.next, struct spu_context,
375 aff_list)->aff_head) {
376 err = ERR_PTR(-EEXIST);
377 goto out_put_neighbor;
378 }
379
380 if (gang != neighbor->gang) {
381 err = ERR_PTR(-EINVAL);
382 goto out_put_neighbor;
383 }
384
385 count = 1;
386 list_for_each_entry(tmp, &gang->aff_list_head, aff_list)
387 count++;
388 if (list_empty(&neighbor->aff_list))
389 count++;
390
391 for (node = 0; node < MAX_NUMNODES; node++) {
392 if ((cbe_spu_info[node].n_spus - atomic_read(
393 &cbe_spu_info[node].reserved_spus)) >= count)
394 break;
395 }
396
397 if (node == MAX_NUMNODES) {
398 err = ERR_PTR(-EEXIST);
399 goto out_put_neighbor;
400 }
401 }
402
403 return neighbor;
404
405out_put_neighbor:
406 put_spu_context(neighbor);
407 return err;
408}
409
410static void
411spufs_set_affinity(unsigned int flags, struct spu_context *ctx,
412 struct spu_context *neighbor)
413{
414 if (flags & SPU_CREATE_AFFINITY_MEM)
415 ctx->gang->aff_ref_ctx = ctx;
416
417 if (flags & SPU_CREATE_AFFINITY_SPU) {
418 if (list_empty(&neighbor->aff_list)) {
419 list_add_tail(&neighbor->aff_list,
420 &ctx->gang->aff_list_head);
421 neighbor->aff_head = 1;
422 }
423
424 if (list_is_last(&neighbor->aff_list, &ctx->gang->aff_list_head)
425 || list_entry(neighbor->aff_list.next, struct spu_context,
426 aff_list)->aff_head) {
427 list_add(&ctx->aff_list, &neighbor->aff_list);
428 } else {
429 list_add_tail(&ctx->aff_list, &neighbor->aff_list);
430 if (neighbor->aff_head) {
431 neighbor->aff_head = 0;
432 ctx->aff_head = 1;
433 }
434 }
435
436 if (!ctx->gang->aff_ref_ctx)
437 ctx->gang->aff_ref_ctx = ctx;
438 }
439}
440
441static int
442spufs_create_context(struct inode *inode, struct dentry *dentry,
443 struct vfsmount *mnt, int flags, int mode,
444 struct file *aff_filp)
445{
446 int ret;
447 int affinity;
448 struct spu_gang *gang;
449 struct spu_context *neighbor;
450
451 ret = -EPERM;
452 if ((flags & SPU_CREATE_NOSCHED) &&
453 !capable(CAP_SYS_NICE))
454 goto out_unlock;
455
456 ret = -EINVAL;
457 if ((flags & (SPU_CREATE_NOSCHED | SPU_CREATE_ISOLATE))
458 == SPU_CREATE_ISOLATE)
459 goto out_unlock;
460
461 ret = -ENODEV;
462 if ((flags & SPU_CREATE_ISOLATE) && !isolated_loader)
463 goto out_unlock;
464
465 gang = NULL;
466 neighbor = NULL;
467 affinity = flags & (SPU_CREATE_AFFINITY_MEM | SPU_CREATE_AFFINITY_SPU);
468 if (affinity) {
469 gang = SPUFS_I(inode)->i_gang;
470 ret = -EINVAL;
471 if (!gang)
472 goto out_unlock;
473 mutex_lock(&gang->aff_mutex);
474 neighbor = spufs_assert_affinity(flags, gang, aff_filp);
475 if (IS_ERR(neighbor)) {
476 ret = PTR_ERR(neighbor);
477 goto out_aff_unlock;
478 }
479 }
480
481 ret = spufs_mkdir(inode, dentry, flags, mode & S_IRWXUGO);
482 if (ret)
483 goto out_aff_unlock;
484
485 if (affinity) {
486 spufs_set_affinity(flags, SPUFS_I(dentry->d_inode)->i_ctx,
487 neighbor);
488 if (neighbor)
489 put_spu_context(neighbor);
490 }
491
492
493
494
495
496 ret = spufs_context_open(dget(dentry), mntget(mnt));
497 if (ret < 0) {
498 WARN_ON(spufs_rmdir(inode, dentry));
499 if (affinity)
500 mutex_unlock(&gang->aff_mutex);
501 mutex_unlock(&inode->i_mutex);
502 spu_forget(SPUFS_I(dentry->d_inode)->i_ctx);
503 goto out;
504 }
505
506out_aff_unlock:
507 if (affinity)
508 mutex_unlock(&gang->aff_mutex);
509out_unlock:
510 mutex_unlock(&inode->i_mutex);
511out:
512 dput(dentry);
513 return ret;
514}
515
516static int
517spufs_mkgang(struct inode *dir, struct dentry *dentry, int mode)
518{
519 int ret;
520 struct inode *inode;
521 struct spu_gang *gang;
522
523 ret = -ENOSPC;
524 inode = spufs_new_inode(dir->i_sb, mode | S_IFDIR);
525 if (!inode)
526 goto out;
527
528 ret = 0;
529 if (dir->i_mode & S_ISGID) {
530 inode->i_gid = dir->i_gid;
531 inode->i_mode &= S_ISGID;
532 }
533 gang = alloc_spu_gang();
534 SPUFS_I(inode)->i_ctx = NULL;
535 SPUFS_I(inode)->i_gang = gang;
536 if (!gang)
537 goto out_iput;
538
539 inode->i_op = &simple_dir_inode_operations;
540 inode->i_fop = &simple_dir_operations;
541
542 d_instantiate(dentry, inode);
543 inc_nlink(dir);
544 inc_nlink(dentry->d_inode);
545 return ret;
546
547out_iput:
548 iput(inode);
549out:
550 return ret;
551}
552
553static int spufs_gang_open(struct dentry *dentry, struct vfsmount *mnt)
554{
555 int ret;
556 struct file *filp;
557
558 ret = get_unused_fd();
559 if (ret < 0) {
560 dput(dentry);
561 mntput(mnt);
562 goto out;
563 }
564
565 filp = dentry_open(dentry, mnt, O_RDONLY, current_cred());
566 if (IS_ERR(filp)) {
567 put_unused_fd(ret);
568 ret = PTR_ERR(filp);
569 goto out;
570 }
571
572 filp->f_op = &simple_dir_operations;
573 fd_install(ret, filp);
574out:
575 return ret;
576}
577
578static int spufs_create_gang(struct inode *inode,
579 struct dentry *dentry,
580 struct vfsmount *mnt, int mode)
581{
582 int ret;
583
584 ret = spufs_mkgang(inode, dentry, mode & S_IRWXUGO);
585 if (ret)
586 goto out;
587
588
589
590
591
592 ret = spufs_gang_open(dget(dentry), mntget(mnt));
593 if (ret < 0) {
594 int err = simple_rmdir(inode, dentry);
595 WARN_ON(err);
596 }
597
598out:
599 mutex_unlock(&inode->i_mutex);
600 dput(dentry);
601 return ret;
602}
603
604
605static struct file_system_type spufs_type;
606
607long spufs_create(struct nameidata *nd, unsigned int flags, mode_t mode,
608 struct file *filp)
609{
610 struct dentry *dentry;
611 int ret;
612
613 ret = -EINVAL;
614
615 if (nd->path.dentry->d_sb->s_type != &spufs_type)
616 goto out;
617
618
619 if (flags & (~SPU_CREATE_FLAG_ALL))
620 goto out;
621
622
623 if (nd->path.dentry != nd->path.dentry->d_sb->s_root) {
624 if ((flags & SPU_CREATE_GANG) ||
625 !SPUFS_I(nd->path.dentry->d_inode)->i_gang)
626 goto out;
627 }
628
629 dentry = lookup_create(nd, 1);
630 ret = PTR_ERR(dentry);
631 if (IS_ERR(dentry))
632 goto out_dir;
633
634 mode &= ~current_umask();
635
636 if (flags & SPU_CREATE_GANG)
637 ret = spufs_create_gang(nd->path.dentry->d_inode,
638 dentry, nd->path.mnt, mode);
639 else
640 ret = spufs_create_context(nd->path.dentry->d_inode,
641 dentry, nd->path.mnt, flags, mode,
642 filp);
643 if (ret >= 0)
644 fsnotify_mkdir(nd->path.dentry->d_inode, dentry);
645 return ret;
646
647out_dir:
648 mutex_unlock(&nd->path.dentry->d_inode->i_mutex);
649out:
650 return ret;
651}
652
653
654enum {
655 Opt_uid, Opt_gid, Opt_mode, Opt_debug, Opt_err,
656};
657
658static const match_table_t spufs_tokens = {
659 { Opt_uid, "uid=%d" },
660 { Opt_gid, "gid=%d" },
661 { Opt_mode, "mode=%o" },
662 { Opt_debug, "debug" },
663 { Opt_err, NULL },
664};
665
666static int
667spufs_parse_options(struct super_block *sb, char *options, struct inode *root)
668{
669 char *p;
670 substring_t args[MAX_OPT_ARGS];
671
672 while ((p = strsep(&options, ",")) != NULL) {
673 int token, option;
674
675 if (!*p)
676 continue;
677
678 token = match_token(p, spufs_tokens, args);
679 switch (token) {
680 case Opt_uid:
681 if (match_int(&args[0], &option))
682 return 0;
683 root->i_uid = option;
684 break;
685 case Opt_gid:
686 if (match_int(&args[0], &option))
687 return 0;
688 root->i_gid = option;
689 break;
690 case Opt_mode:
691 if (match_octal(&args[0], &option))
692 return 0;
693 root->i_mode = option | S_IFDIR;
694 break;
695 case Opt_debug:
696 spufs_get_sb_info(sb)->debug = 1;
697 break;
698 default:
699 return 0;
700 }
701 }
702 return 1;
703}
704
705static void spufs_exit_isolated_loader(void)
706{
707 free_pages((unsigned long) isolated_loader,
708 get_order(isolated_loader_size));
709}
710
711static void
712spufs_init_isolated_loader(void)
713{
714 struct device_node *dn;
715 const char *loader;
716 int size;
717
718 dn = of_find_node_by_path("/spu-isolation");
719 if (!dn)
720 return;
721
722 loader = of_get_property(dn, "loader", &size);
723 if (!loader)
724 return;
725
726
727 isolated_loader = (char *)__get_free_pages(GFP_KERNEL, get_order(size));
728 if (!isolated_loader)
729 return;
730
731 isolated_loader_size = size;
732 memcpy(isolated_loader, loader, size);
733 printk(KERN_INFO "spufs: SPU isolation mode enabled\n");
734}
735
736static int
737spufs_create_root(struct super_block *sb, void *data)
738{
739 struct inode *inode;
740 int ret;
741
742 ret = -ENODEV;
743 if (!spu_management_ops)
744 goto out;
745
746 ret = -ENOMEM;
747 inode = spufs_new_inode(sb, S_IFDIR | 0775);
748 if (!inode)
749 goto out;
750
751 inode->i_op = &simple_dir_inode_operations;
752 inode->i_fop = &simple_dir_operations;
753 SPUFS_I(inode)->i_ctx = NULL;
754 inc_nlink(inode);
755
756 ret = -EINVAL;
757 if (!spufs_parse_options(sb, data, inode))
758 goto out_iput;
759
760 ret = -ENOMEM;
761 sb->s_root = d_alloc_root(inode);
762 if (!sb->s_root)
763 goto out_iput;
764
765 return 0;
766out_iput:
767 iput(inode);
768out:
769 return ret;
770}
771
772static int
773spufs_fill_super(struct super_block *sb, void *data, int silent)
774{
775 struct spufs_sb_info *info;
776 static const struct super_operations s_ops = {
777 .alloc_inode = spufs_alloc_inode,
778 .destroy_inode = spufs_destroy_inode,
779 .statfs = simple_statfs,
780 .delete_inode = spufs_delete_inode,
781 .drop_inode = generic_delete_inode,
782 .show_options = generic_show_options,
783 };
784
785 save_mount_options(sb, data);
786
787 info = kzalloc(sizeof(*info), GFP_KERNEL);
788 if (!info)
789 return -ENOMEM;
790
791 sb->s_maxbytes = MAX_LFS_FILESIZE;
792 sb->s_blocksize = PAGE_CACHE_SIZE;
793 sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
794 sb->s_magic = SPUFS_MAGIC;
795 sb->s_op = &s_ops;
796 sb->s_fs_info = info;
797
798 return spufs_create_root(sb, data);
799}
800
801static int
802spufs_get_sb(struct file_system_type *fstype, int flags,
803 const char *name, void *data, struct vfsmount *mnt)
804{
805 return get_sb_single(fstype, flags, data, spufs_fill_super, mnt);
806}
807
808static struct file_system_type spufs_type = {
809 .owner = THIS_MODULE,
810 .name = "spufs",
811 .get_sb = spufs_get_sb,
812 .kill_sb = kill_litter_super,
813};
814
815static int __init spufs_init(void)
816{
817 int ret;
818
819 ret = -ENODEV;
820 if (!spu_management_ops)
821 goto out;
822
823 ret = -ENOMEM;
824 spufs_inode_cache = kmem_cache_create("spufs_inode_cache",
825 sizeof(struct spufs_inode_info), 0,
826 SLAB_HWCACHE_ALIGN, spufs_init_once);
827
828 if (!spufs_inode_cache)
829 goto out;
830 ret = spu_sched_init();
831 if (ret)
832 goto out_cache;
833 ret = register_filesystem(&spufs_type);
834 if (ret)
835 goto out_sched;
836 ret = register_spu_syscalls(&spufs_calls);
837 if (ret)
838 goto out_fs;
839
840 spufs_init_isolated_loader();
841
842 return 0;
843
844out_fs:
845 unregister_filesystem(&spufs_type);
846out_sched:
847 spu_sched_exit();
848out_cache:
849 kmem_cache_destroy(spufs_inode_cache);
850out:
851 return ret;
852}
853module_init(spufs_init);
854
855static void __exit spufs_exit(void)
856{
857 spu_sched_exit();
858 spufs_exit_isolated_loader();
859 unregister_spu_syscalls(&spufs_calls);
860 unregister_filesystem(&spufs_type);
861 kmem_cache_destroy(spufs_inode_cache);
862}
863module_exit(spufs_exit);
864
865MODULE_LICENSE("GPL");
866MODULE_AUTHOR("Arnd Bergmann <arndb@de.ibm.com>");
867
868
